Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Show missing nutrients in Nutri-Score panel #10655

Merged
merged 16 commits into from
Aug 13, 2024

Conversation

stephanegigandet
Copy link
Contributor

The Nutri-Score panel currently says if nutrition data is missing, but not which exact nutrients are missing:

image

This PR lists the missing nutrients:

image

Fixes #7609

@stephanegigandet stephanegigandet requested a review from a team as a code owner August 7, 2024 15:08
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display 🌐 Translations labels Aug 7, 2024
@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 tests 🧪 integration tests labels Aug 7, 2024
Copy link

sonarcloud bot commented Aug 7, 2024

@stephanegigandet stephanegigandet merged commit a1b11eb into main Aug 13, 2024
13 checks passed
@stephanegigandet stephanegigandet deleted the nutriscore-panel-missing-nutrition branch August 13, 2024 12:48
stephanegigandet pushed a commit that referenced this pull request Aug 13, 2024
🤖 I have created a release *beep* *boop*
---


##
[2.41.0](v2.40.0...v2.41.0)
(2024-08-13)


### Features

* generate historical events from product revisions
([#10523](#10523))
([42508e1](42508e1))
* sync number of product public/pro in CRM
([#10684](#10684))
([026ff6a](026ff6a))


### Bug Fixes

* 3 fixes to make /products/[code1],[code2] work again
([#10669](#10669))
([7fc07fc](7fc07fc))
* Automatically unselect images when source image is deleted
([#10692](#10692))
([588897a](588897a))
* **docs:** correct OpenAPI definition by fixing missing reference
([#10659](#10659))
([4f0f10e](4f0f10e))
* gen_users_emails.pl
([#10686](#10686))
([00e4c26](00e4c26))
* Show missing nutrients in Nutri-Score panel
([#10655](#10655))
([a1b11eb](a1b11eb))
* UTM mobile
([#10665](#10665))
([965041d](965041d))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Display 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🚦 Nutri-Score ⭐ top pull request Top pull request. Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests 🌐 Translations
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

In the Nutri-Score knowledge panel, indicate the missing nutriments that prevent computing the Nutri-Score
3 participants